Jacob Creedon has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34490 )
Change subject: flashchips: Add missing MT25Q erase commands ......................................................................
flashchips: Add missing MT25Q erase commands
This adds additional 32KiB subsecor erase commands 0x5c and 0x52 and an additional bulk erase command of 0x60.
Signed-off-by: Jacob Creedon jcreedon@google.com Change-Id: I5307c4b96cbd62203f5bad0c94737180fda621aa --- M flashchips.c 1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/34490/1
diff --git a/flashchips.c b/flashchips.c index 78873eb..d25f7a2 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10646,6 +10646,12 @@ .eraseblocks = { {4 * 1024, 8192} }, .block_erase = spi_block_erase_20, }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = spi_block_erase_5c, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = spi_block_erase_52, + }, { .eraseblocks = { {64 * 1024, 512} }, .block_erase = spi_block_erase_dc, }, { @@ -10654,6 +10660,9 @@ }, { .eraseblocks = { {32768 * 1024, 1} }, .block_erase = spi_block_erase_c7, + }, { + .eraseblocks = { {32768 * 1024, 1} }, + .block_erase = spi_block_erase_60, } }, .printlock = spi_prettyprint_status_register_n25q, /* TODO: config, lock, flag regs */ @@ -10686,6 +10695,12 @@ .eraseblocks = { {4 * 1024, 16384} }, .block_erase = spi_block_erase_20, }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = spi_block_erase_5c, + }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = spi_block_erase_52, + }, { .eraseblocks = { {64 * 1024, 1024} }, .block_erase = spi_block_erase_dc, }, { @@ -10694,6 +10709,9 @@ }, { .eraseblocks = { {65536 * 1024, 1} }, .block_erase = spi_block_erase_c7, + }, { + .eraseblocks = { {65536 * 1024, 1} }, + .block_erase = spi_block_erase_60, } }, .printlock = spi_prettyprint_status_register_n25q, /* TODO: config, lock, flag regs */
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/34490
to look at the new patch set (#3).
Change subject: flashchips: Add missing MT25Q erase commands ......................................................................
flashchips: Add missing MT25Q erase commands
This adds additional 32KiB subsector erase commands 0x5c and 0x52 and an additional bulk erase command of 0x60.
Signed-off-by: Jacob Creedon jcreedon@google.com Change-Id: I5307c4b96cbd62203f5bad0c94737180fda621aa --- M flashchips.c 1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/34490/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34490 )
Change subject: flashchips: Add missing MT25Q erase commands ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/34490/3/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34490/3/flashchips.c@10628 PS3, Line 10628: 64KB/4KB Nit, should this comment be adapted? I don't know (actually, I don't know why there is a comment at all)
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34490 )
Change subject: flashchips: Add missing MT25Q erase commands ......................................................................
Patch Set 3: Verified+1
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/34490 )
Change subject: flashchips: Add missing MT25Q erase commands ......................................................................
flashchips: Add missing MT25Q erase commands
This adds additional 32KiB subsector erase commands 0x5c and 0x52 and an additional bulk erase command of 0x60.
Signed-off-by: Jacob Creedon jcreedon@google.com Change-Id: I5307c4b96cbd62203f5bad0c94737180fda621aa Reviewed-on: https://review.coreboot.org/c/flashrom/+/34490 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M flashchips.c 1 file changed, 18 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/flashchips.c b/flashchips.c index 1ab48ad..f8d336e 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10646,6 +10646,12 @@ .eraseblocks = { {4 * 1024, 8192} }, .block_erase = spi_block_erase_20, }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = spi_block_erase_5c, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = spi_block_erase_52, + }, { .eraseblocks = { {64 * 1024, 512} }, .block_erase = spi_block_erase_dc, }, { @@ -10654,6 +10660,9 @@ }, { .eraseblocks = { {32768 * 1024, 1} }, .block_erase = spi_block_erase_c7, + }, { + .eraseblocks = { {32768 * 1024, 1} }, + .block_erase = spi_block_erase_60, } }, .printlock = spi_prettyprint_status_register_n25q, /* TODO: config, lock, flag regs */ @@ -10686,6 +10695,12 @@ .eraseblocks = { {4 * 1024, 16384} }, .block_erase = spi_block_erase_20, }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = spi_block_erase_5c, + }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = spi_block_erase_52, + }, { .eraseblocks = { {64 * 1024, 1024} }, .block_erase = spi_block_erase_dc, }, { @@ -10694,6 +10709,9 @@ }, { .eraseblocks = { {65536 * 1024, 1} }, .block_erase = spi_block_erase_c7, + }, { + .eraseblocks = { {65536 * 1024, 1} }, + .block_erase = spi_block_erase_60, } }, .printlock = spi_prettyprint_status_register_n25q, /* TODO: config, lock, flag regs */
-
Jacob Creedon (Code Review) -
Nico Huber (Code Review)