Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 )
Change subject: hwaccess_x86_io: clean header concept ......................................................................
Patch Set 9:
(3 comments)
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/ca4794cd_cd98a1e3 PS6, Line 30: * - X86_IO_USE_LIBC : * - X86_IO_USE_SWAPPED
How about more accurate names, e.g. […]
Yes, more accurate naming would be good. Working on it.
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/80e280c4_846f77c9 PS7, Line 36: * functions. `platform_get_io_perms()` is called to get
Please drop the trailing whitespace that Gerrit marks so keenly.
Done
https://review.coreboot.org/c/flashrom/+/61276/comment/995489cf_b5b6275b PS7, Line 352: a
ass*e*mbly
Done
-
Thomas Heijligen (Code Review)