Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57635 )
Change subject: Add support for Intel Emmitsburg PCH ......................................................................
Patch Set 3:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/57635/comment/6437a28a_d4021088 PS3, Line 952: Ibex Peak is historically used as the default
I wouldn't say "should" but it definitely could.
Exactly, and that's why we're in this huge debate ;-) This ambiguity of intentions is exactly why we should match values (or ranges) to a specific chipset whenever possible, and document why the default value was chosen, especially if it's not the newest platform anymore.
Personally, as this branch seems complex enough already, I'd first check if there is no easier way to distinguish server descriptors from client ones.
I actually did spend some time looking at this, and unfortunately there does not appear to be a reliable way. Intel does not version the IFD (AFAIK), and for the most part the layout is similar.
The most obvious difference I saw is that server chips tend to have a large ISL value (more straps) compared to non-server chips.
However, the SPI IP block seems common among client and server chips. We even call the chip enable function `enable_flash_pch100_or_c620()`.
Also, please note that everything done about Emmitsburg so far (including what I wrote above) makes the assumption that it's right to return _LEWISBURG for it. I don't know if that is correct.
Yes, LBG and EBG are very similar for flashrom's purposes just like Lynx Point and Wildcat Point. Read, write, and erase using layouts has been done a lot at this point.
-
David Hendricks (Code Review)