Attention is currently required from: Nico Huber, Namyoon Woo, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Namyoon Woo, Edward O'Callaghan, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/54748
to look at the new patch set (#4).
Change subject: dummyflasher.c: Extract params processing into a separate function ......................................................................
dummyflasher.c: Extract params processing into a separate function
This makes init function easier to read.
A good side-effect of the change is: 13 error paths of params processing are not leaking data anymore. All those error paths return 1 back to init function which frees data.
And there was just one more error path in init function were free(data) needed to be added.
BUG=b:185191942 TEST=ninja test
Change-Id: I04f55f77bb4703f1d88b2191c45a22be3c97bf87 Signed-off-by: Anastasia Klimchuk aklm@chromium.org --- M dummyflasher.c 1 file changed, 51 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/54748/4