[L] Change in flashrom[master]: flashrom.c: Add wrapper function to use the erase algorithm - flashrom-gerrit

30 Sep 2022


      Attention is currently required from: Nico Huber, Thomas Heijligen.
Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm
......................................................................
Patch Set 61:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/6b7c445e_70a727a0 
PS52, Line 1057: flashctx->chip->page_size
...
Done
I´m fine with this implementation: Using page_size and making sure that all (test) chips have a valid page_size. However there might be use cases I do not have in mind?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 61
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Fri, 30 Sep 2022 06:57:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Aarya aarya.chaumal@gmail.com
Gerrit-MessageType: comment