Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49255 )
Change subject: bitbang-spi.c: support clock polarity and phase ......................................................................
Patch Set 12: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49255/comment/7e077dbe_04cd0187 PS12, Line 12: . Also state the previous mode here that is currently assumed.
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/49255/comment/1acb15d7_49918d2f PS12, Line 208: : if (parse_spi_mode(&cpol, &cpha)) : return ERROR_FLASHROM_BUG; Hmm, the only thing is this could be a little too harsh for this patch in that, could we just assume the previous behavior when no param is passed? So just set cpol, cpha on the error branch here with values that make the patch a nop for other users and previous use-cases.
The case of changing behavior can be its own patch with its own debate, it would definitely need a man page correction as well.
-
Edward O'Callaghan (Code Review)