[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Shreeyash .
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 )
Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ......................................................................
Patch Set 2:
(1 comment)
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/66225/comment/ffce6a9f_46f62938 PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx, Shreeyash,
First of all, thank you for your work and for your enthusiasm to contribute to flashrom! There are few important things that I want to say.
We expect a certain level of knowledge of Git (and C) from our contributors. We also expect a certain level of independence and self-discipline. I really want to encourage you to take a step back, and do a self-study of the basics of Git, and try to answer the questions you were asking in this thread by yourself. For example, in your message from Oct 22 you are saying:
Second, Following my to-do list, I did 1,2 and edited stlinkv3_spi.c, to add a comment over the only change that this patch does. git commit --amend after returns fatal: You are in the middle of a cherry-pick -- cannot amend. Again, How do I update a commit?
At this point, take the message “fatal: You are in the middle of a cherry-pick -- cannot amend”, take your favourite internet search engine and start searching. I can promise you will find lots of resources: threads on stackoverflow, blog posts, tutorial websites etc etc. Your main task is to understand what actually happened and what you should do next. Same thing with running `git status`. If people ask you to run `git status`, you do it. And then, instead of posting output here and asking “so what do i do now?” you do the same as before: search the internet. And find the answer by yourself! :)
You can do any experiments in your local git repository: create lots of local branches and try doing various things and see what happens! And learn. You can take this thread as an exercise and go through it, and understand what has happened. If you are in the uni, you can group with other enthusiasts, and learn together!
Git documentation: https://git-scm.com/book/en/v2 Gerrit code review for Git: https://gerrit-review.googlesource.com/Documentation/
Everything is in your hands. Good luck!
-
Anastasia Klimchuk (Code Review)