Attention is currently required from: Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71973 )
Change subject: flashrom_tester: Rewrite IOOpts to support more operations
......................................................................
Patch Set 7:
(1 comment)
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/71973/comment/f437ad22_986ca713
PS6, Line 73: Option
What you've got in PS7 seems reasonable, but I'd like some inline documentation on the fields becaus […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/71973
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1cb46bb1b26949fd9c19949c43708a8b652e00da
Gerrit-Change-Number: 71973
Gerrit-PatchSet: 7
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Tue, 24 Jan 2023 01:14:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Comment-In-Reply-To: Evan Benn
evanbenn@google.com
Gerrit-MessageType: comment