Attention is currently required from: Paul Menzel, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 )
Change subject: hwaccess: fix build on non-x86 targets ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Patchset:
PS4: I've updated the Makefile for building the internal programmer on mipsle. On other platforms the internal programmer will fail to initialize.
File hwaccess_x86_io.h:
https://review.coreboot.org/c/flashrom/+/61194/comment/4d66f73d_887aa833 PS4, Line 41: #define HAVE_RGET_IO_PERMS 1 not needed
File internal.c:
https://review.coreboot.org/c/flashrom/+/61194/comment/18d245b4_9bf7bd3a PS4, Line 245: if (rget_io_perms()) { You can move this under the x86 guard at line 275. No need for HAVE_RGET_IO_PERMS
-
Thomas Heijligen (Code Review)