Change in flashrom[master]: Add -W options from Makefile into meson warning_flags - flashrom-gerrit

8 Apr 2022


      Attention is currently required from: Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58561 )
Change subject: Add -W options from Makefile into meson warning_flags
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2:
...
My next steps are to sync optimisation option and Werror. […]
Maybe we can combine Werror with the buildtype?
PS2: 
Meson has build-in support for warnings. Maybe it's better to use them.
*Consider using the built-in warning_level option instead of using "-Wall"*
*Consider using the built-in warning_level option instead of using "-Wextra"*
https://mesonbuild.com/Builtin-options.html
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58561
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id401bfd642dc3c13d85bd9a2dba56ada38714c25
Gerrit-Change-Number: 58561
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Peter Marheine pmarheine@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Fri, 08 Apr 2022 12:37:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment