[S] Change in flashrom[master]: tests: Add unit test for initialisation with NULL programmer param - flashrom-gerrit

15 Sep 2022


      Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67642 )
Change subject: tests: Add unit test for initialisation with NULL programmer param
......................................................................
Patch Set 2:
(1 comment)
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/67642/comment/73d5a4fc_0561c96c 
PS1, Line 44: if (param != NULL)
...
`if (param)` is sufficient and canonical.
Ack
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/67642
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I409f1c9ac832943e54107f7cf8652d1f46ac67df
Gerrit-Change-Number: 67642
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Thu, 15 Sep 2022 03:42:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment