David Hendricks has posted comments on this change. ( https://review.coreboot.org/18740 )
Change subject: Enable writes with active ME
......................................................................
Patch Set 15: Code-Review+2
I made an attempt to address this a couple months ago, but it turned out to be kinda messy. Basically, the programmer/chip code needs to be able to read the layout in order to determine what operations are possible in the user-specified region(s). Or, the layout code needs to know about any restrictions from the programmer/chip.
Long story short, a real fix might be a ways off and this removes a barrier for people doing things the right way. So LGTM.
--
To view, visit
https://review.coreboot.org/18740
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef
Gerrit-Change-Number: 18740
Gerrit-PatchSet: 15
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philippe Mathieu-Daudé
f4bug@amsat.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 Dec 2017 07:44:08 +0000
Gerrit-HasComments: No