[S] Change in flashrom[main]: flashchips: Add write-protect support for GD25LQ255E

[Tyler Wang (Code Review)]

Attention is currently required from: Anastasia Klimchuk, David Wu, Hsuan-ting Chen, Kapil Porwal, Lean Sheng Tan, Nikolai Artemiev, Stefan Reinauer.

Hello Anastasia Klimchuk, David Wu, Hsuan-ting Chen, Kapil Porwal, Lean Sheng Tan, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/flashrom/+/79460?usp=email

to look at the new patch set (#10).


Change subject: flashchips: Add write-protect support for GD25LQ255E
......................................................................

flashchips: Add write-protect support for GD25LQ255E

datasheet: https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20221129/DS-00...

BUG=b:311336475
TEST=Verified on karis

w/o this patch:
$ flashrom_tester --flashrom_binary ./flashrom internal Lock_top_quad
  --> Failed

w/ this patch:
$ flashrom_tester --flashrom_binary ./flashrom internal Lock_top_quad
  --> Pass

This lock_top_quad test did(copied from partial_lock_test()):
* Disable hardware WP so we can modify the protected range.
* Then enable software WP so the range is enforced and enable
  hardware WP so that flashrom does not disable software WP during the
  operation.
* Check that we cannot write to the protected region.
* Check that we can write to the non protected region.

Change-Id: I1425e931433c00caceaabc6037a79099d6d5eac5
Signed-off-by: Tyler Wang <[e-mail]>
---
M flashchips.c
1 file changed, 11 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/79460/10
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/79460?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I1425e931433c00caceaabc6037a79099d6d5eac5
Gerrit-Change-Number: 79460
Gerrit-PatchSet: 10
Gerrit-Owner: Tyler Wang <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: David Wu <[e-mail]>
Gerrit-Reviewer: Hsuan-ting Chen <[e-mail]>
Gerrit-Reviewer: Kapil Porwal <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: Stefan Reinauer <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Subrata Banik <[e-mail]>
Gerrit-Attention: David Wu <[e-mail]>
Gerrit-Attention: Hsuan-ting Chen <[e-mail]>
Gerrit-Attention: Stefan Reinauer <[e-mail]>
Gerrit-Attention: Kapil Porwal <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Attention: Lean Sheng Tan <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-MessageType: newpatchset