Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59239 )
Change subject: tests: Add tests for verify operation
......................................................................
Patch Set 5:
(4 comments)
Patchset:
PS5:
All tests upgraded and are using libflashrom API now!
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/59239/comment/2d9b7f7f_8f1ea256
PS4, Line 377: do_verify
please target the libflashrom API not the CLI helpers.
Done
https://review.coreboot.org/c/flashrom/+/59239/comment/b9c7362e_061f9d02
PS4, Line 417: do_write
ditto
Done
https://review.coreboot.org/c/flashrom/+/59239/comment/bedac4c1_563401f5
PS4, Line 421: do_verify
ditto
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1cc6f73f9b1e385eb963adccf20759c13a40ed3b
Gerrit-Change-Number: 59239
Gerrit-PatchSet: 5
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 17 Jan 2022 23:53:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment
Anastasia Klimchuk (Code Review)