Attention is currently required from: Alexander Goncharov, Nikolai Artemiev, Peter Marheine, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/83359?usp=email )
Change subject: doc: Release notes for version 1.4.0 ......................................................................
Patch Set 2:
(7 comments)
Patchset:
PS2: Peter thank you so much, your suggestions made this doc so much better!
File doc/release_notes/v_1_4.rst:
https://review.coreboot.org/c/flashrom/+/83359/comment/5e00a6fc_fc30bc69?usp... : PS1, Line 5: Release notes for flashrom version 1.4.0.
It seems nice to include a little intro paragraph here, acknowledging contributors and providing a l […]
This is a great idea! How could I forgot :(
I added a paragraph, with few changes: 400+ and 70+ instead of exact numbers, to count all possible fixed in rc.
Also I am not entirely sure how to count months: 1.3 got out in Feb 2023, but it was made based on a branch which diverged in early Nov 2022. And during those 3.5 months active development continued, but except of few small fixed, not included in 1.3. There is no easy way to say this in short, so I settled on "in the 18 months since version 1.3.0 was branched" which seems close enough to reality. We won't have this problem again :)
https://review.coreboot.org/c/flashrom/+/83359/comment/99353e55_8aad7e3a?usp... : PS1, Line 10: Fix AMD programmer (sb600spi.c) for Promontory and chips >16MB size
I see this is the title of the issue, but starting a known issue with "Fix" seems confusing. […]
This is great summary!
https://review.coreboot.org/c/flashrom/+/83359/comment/faa02cde_16857b71?usp... : PS1, Line 29: : * Calibration loop is not used anymore, except for DOS : * Removed unconditional 1 second delay for SPI chips : * Lower the sleep vs delay threshold to 0.1 seconds : * Tree-wide refactorings around programmer_delay and internal_delay
This is technically all true, but I think it should be rearranged to highlight the parts that users […]
Done
https://review.coreboot.org/c/flashrom/+/83359/comment/338bfa18_ff346891?usp... : PS1, Line 38: Note: the migration process is half way.
Should this mention that the wiki is deprecated and will go away eventually, but information from th […]
Yes good idea I added this info.
https://review.coreboot.org/c/flashrom/+/83359/comment/e3fa4d80_6eab39ce?usp... : PS1, Line 46: Our current two build systems, meson and make, are on par : --------------------------------------------------------- : : Both build systems support the same platforms and both are documented (however, unit tests only supported with meson). : : **This is the last release with two build systems. With the next release, make and Makefile will no longer be supported, and we will have one build system: meson.**
As with the delay section, I think this should highlight things that might affect users (or in this […]
Done
https://review.coreboot.org/c/flashrom/+/83359/comment/fd834aee_88534a40?usp... : PS1, Line 292: Download
I think this should be at the top, right after the intro paragraph.
Done
-
Anastasia Klimchuk (Code Review)