[S] Change in flashrom[master]: [WIP] Emulate multithreading env for unit tests on OpenBSD
Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74157 )
Change subject: [WIP] Emulate multithreading env for unit tests on OpenBSD ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Good news: tests pass on OpenBSD with the patchset2! […]
Yes, I'd prefer to always create a thread and get rid of the `__isthreaded` poke for other BSDs. It seems fine to also spawn a do-nothing thread on platforms where we don't need to, since the cost is small.
File tests/meson.build:
https://review.coreboot.org/c/flashrom/+/74157/comment/f9accb29_aef3d6bb PS1, Line 124: '-Dpthread',
Thank you! […]
Might be that it ends up included through a pthread header; I fixed an error relating to that by adding the include before I fixed the pthread errors. If it works without changing the includes I don't think it needs any changes.
-
Peter Marheine (Code Review)