Attention is currently required from: Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50711 )
Change subject: tree: Removing forward-declarations for spi masters
......................................................................
Patch Set 1:
(1 comment)
File serprog.c:
PS1:
Likewise what Angel said about dummyflasher.c, serprog.c is a little on the large size >200loc diff so it _maybe_ worth while splitting it out as well. Although I'll defer to the communities feelings on this as an authority.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/50711
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I23ff6b79d794876f73b327f18784ca7c04c32c84
Gerrit-Change-Number: 50711
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 15 Feb 2021 00:16:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment