Attention is currently required from: Felix Singer, Idwer Vollering, Angel Pons.
Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62761 )
Change subject: board_enable.c: Remove unnecessary assignment
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62761/comment/b2bd474f_27081558
PS7, Line 7: Fix dead assignment
Well, actually this doesn't fix something. How about: […]
Done
https://review.coreboot.org/c/flashrom/+/62761/comment/54d9a400_f6bed945
PS7, Line 9: In function board_asus_p3b_f there were two consecutive lines which
: modified the value of variable b -- b=INB(0x80);b=INB(smbba);. Since the
: value of b is not used after first assignment I have removed that
: assignment.
If you want to comment on code in a commit message, I would format this as I did below to make it mo […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62761
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc
Gerrit-Change-Number: 62761
Gerrit-PatchSet: 8
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 25 Mar 2022 04:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment