Attention is currently required from: Daniel Campello, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62844 )
Change subject: tests: add more mock wrappers
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62844/comment/61005546_648a7b19
PS1, Line 9: This change allows for tests to run when the compiler is inlining some
: other interfaces.
While I know what you mean here about clang but can you elaborate in a similar fashion to the coreboot patch this was inspired from?
https://review.coreboot.org/plugins/gitiles/coreboot/+/ab9140773581f072ce361...
i.e., what is actually happening here that means `__open64_2()` is needed?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9776104d655c37891093da08789d37e5e27700de
Gerrit-Change-Number: 62844
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 16 Mar 2022 23:23:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment