Attention is currently required from: Matti Finder.
Anastasia Klimchuk has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84934?usp=email )
Change subject: rpmc: add rpmc commands feature ......................................................................
Patch Set 8:
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/84934/comment/b8964c4c_c7be3d93?usp... : PS8, Line 177: get_option('rpmc').allowed()
So, I downloaded the patch locally, to try and build it, and discover something. […]
I found the trace where current minimum 0.56.0 comes from:
In this patch https://review.coreboot.org/c/flashrom/+/73361 there is a link (in the first comment) that Debian Bullseye ships 0.56.2 https://packages.debian.org/bullseye/meson
And maybe we can talk about upgrading the minimum, but I definitely don't want to hold this patch for that. I would rather change it too use the "old-style" construction (get_option('rpmc').auto() or get_option('rpmc').enabled()) and get this merged. If later we upgrade the meson version, we will upgrade to isAllowed() everywhere.
So, I suggest to change the lines 177-181 to
``` if (get_option('rpmc').auto() or get_option('rpmc').enabled()) and libcrypto.found() add_project_arguments('-DCONFIG_RPMC_ENABLED=1', language : 'c') srcs += 'rpmc.c' deps += libcrypto endif ```