Change in flashrom[master]: dummyflasher.c: Fix memory leak on shutdown - flashrom-gerrit

21 Apr 2021


      Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52557 )
Change subject: dummyflasher.c: Fix memory leak on shutdown
......................................................................
Patch Set 1:
(2 comments)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/52557/comment/8881bc78_27d911c1 
PS1, Line 716: 			return 1;
...
Yes it does. […]
Ack
https://review.coreboot.org/c/flashrom/+/52557/comment/3eab97d5_373043d0 
PS1, Line 986: 			return 1;
...
Yes, malloc should be at the end I think. […]
Sounds good!
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52557
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I36f76d84d3547d081c64857e06da23ee63cc5594
Gerrit-Change-Number: 52557
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Wed, 21 Apr 2021 00:19:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment