Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 )
Change subject: ich_descriptors.c: Ensure unsigned types >=0 on to prevent underflow
......................................................................
Patch Set 16:
(4 comments)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62764/comment/43e6be86_b9625b93
PS14, Line 501: for (j = 0; j < (size_t)min(num_regions, 12); j++)
Thanks so much for explanation! […]
Yeah that sounds about right.
https://review.coreboot.org/c/flashrom/+/62764/comment/6ad933b1_1b342f80
PS14, Line 505: for (j = 12; j < num_regions; j++)
ditto
Done
https://review.coreboot.org/c/flashrom/+/62764/comment/c2b8fec7_c0e11e16
PS14, Line 507: 12
ditto
Done
https://review.coreboot.org/c/flashrom/+/62764/comment/6a032ba1_0b5fbf67
PS14, Line 508: 12
ditto
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5921cc571f3dca5188ca1973dba6ececbcbe2f39
Gerrit-Change-Number: 62764
Gerrit-PatchSet: 16
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 05 Apr 2022 12:25:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Light
aarya.chaumal@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment