Change in flashrom[master]: flashchips: Fix N25Q512 bulk erase

[Jacob Creedon (Code Review)]

Jacob Creedon has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34489 )

Change subject: flashchips: Fix N25Q512 bulk erase
......................................................................

flashchips: Fix N25Q512 bulk erase

The N25Q is a stacked device, so it requires 0xC4 to perform a die
erase.

Signed-off-by: Jacob Creedon 
Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84
---
M flashchips.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/34489/1

diff --git a/flashchips.c b/flashchips.c
index e6116ae..78873eb 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -10613,7 +10613,7 @@
    			.block_erase = spi_block_erase_d8,
    		}, {
    			.eraseblocks = { {65536 * 1024, 1} },
-				.block_erase = spi_block_erase_c7,
+				.block_erase = spi_block_erase_c4,
    		}
    	},
    	.printlock	= spi_prettyprint_status_register_n25q, /* TODO: config, lock, flag regs */

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34489 )

Change subject: flashchips: Fix N25Q512 bulk erase
......................................................................

Patch Set 1:

Is that in the datasheet?

[Jacob Creedon (Code Review)]

Jacob Creedon has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34489 )

Change subject: flashchips: Fix N25Q512 bulk erase
......................................................................

Patch Set 1:
> Patch Set 1:
>
> Is that in the datasheet?

For example, in https://www.micron.com/-/media/documents/products/data-sheet/nor-flash/seria... the first page only lists subsector, sector, and die erase under erase capability. Note that the datasheet later on does provide documentation for the bulk erase functionality, however, I think this is included due to a copy paste error. Another data point is provided by TN-25-01 (https://www.micron.com/-/media/client/global/documents/products/technical-no...): page 5 outlines the different commands and describes bulk erase being for single die devices only, and die erase for stacked devices only. TN-25-05 (https://www.micron.com/-/media/client/global/documents/products/technical-no...) also goes into stacked devices, and implies that the most you can erase at a time is a single die.

[Jacob Creedon (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/34489

to look at the new patch set (#2).

Change subject: flashchips: Fix N25Q512 bulk erase
......................................................................

flashchips: Fix N25Q512 bulk erase

The N25Q is a stacked device, so it requires 0xC4 to perform a die
erase.

Signed-off-by: Jacob Creedon 
Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84
---
M flashchips.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/34489/2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34489 )

Change subject: flashchips: Fix N25Q512 bulk erase
......................................................................

Patch Set 2: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/34489 )

Change subject: flashchips: Fix N25Q512 bulk erase
......................................................................

flashchips: Fix N25Q512 bulk erase

The N25Q is a stacked device, so it requires 0xC4 to perform a die
erase.

Signed-off-by: Jacob Creedon 
Change-Id: Ib408fbe5633abd8b657e3907142b997e88b33f84
Reviewed-on: https://review.coreboot.org/c/flashrom/+/34489
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
---
M flashchips.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/flashchips.c b/flashchips.c
index 31a922e..1ab48ad 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -10612,8 +10612,8 @@
    			.eraseblocks = { {64 * 1024, 1024} },
    			.block_erase = spi_block_erase_d8,
    		}, {
-				.eraseblocks = { {65536 * 1024, 1} },
-				.block_erase = spi_block_erase_c7,
+				.eraseblocks = { {32768 * 1024, 2} },
+				.block_erase = spi_block_erase_c4,
    		}
    	},
    	.printlock	= spi_prettyprint_status_register_n25q, /* TODO: config, lock, flag regs */