Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 )
Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56023/comment/ff0aebbc_b073d875 PS1, Line 7: board_enable.c: Add ME unlock function for TUXEDO laptops
Still working on that, because after rebase something broke... […]
Okay, the bug was in the acpi_ec patch and now it works correctly.
Commit Message:
https://review.coreboot.org/c/flashrom/+/56023/comment/e04993bd_823f9297 PS2, Line 9: baord
board
Done
File board_enable.c:
https://review.coreboot.org/c/flashrom/+/56023/comment/ddb06de7_4f1da9a6 PS2, Line 2310: tuxedo
btw. the initial discussion was about the function name and that is still valid. […]
Done
https://review.coreboot.org/c/flashrom/+/56023/comment/d4375138_d5aa0c1e PS2, Line 2331: 0xda
Read again what I wrote. […]
Not naming it at all is good as well for now. Although it probably means Win dows Flash or something like that...
https://review.coreboot.org/c/flashrom/+/56023/comment/60a239c3_40804150 PS2, Line 2335: power off the system and power it on
Tested with AC plugged. The simple shutdown through APCI is enough, EC FW takes care of the rest.
After a second thought I think we shall leave the decision to user to do the power off. Added an msg_pinfo with a message what to do to take effect. Also this board enable is going to be used with fwupd, it would be bad if suddenly the laptop will power off. fwupd could probably handle it more gracefully.
https://review.coreboot.org/c/flashrom/+/56023/comment/a4ab2ada_49fb356d PS2, Line 2339: return 0;
The reason to set the strap is when someone wants to write IFD and ME region. […]
If we unlock the ME successfully we return -1 so that the flashrom will not proceed with flashing and user could power cycle the device first. Of course the user must explicitly pass the programmer option for flashrom to take this path, so I think it might be good as it is now.
-
Michał Żygowski (Code Review)