[S] Change in flashrom[master]: meson: Move programmer test sources into programmer definition

[Felix Singer (Code Review)]

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68162 )

Change subject: meson: Move programmer test sources into programmer definition
......................................................................

Patch Set 15:

(1 comment)

File tests/meson.build:

https://review.coreboot.org/c/flashrom/+/68162/comment/39ffb27a_d3f461d8 
PS10, Line 32:   p_data += {
             :     'testsrc' : p_data.get('testsrc', []),
             :   }
             :   srcs += p_data.get('testsrc')
> See also line 440 in the top-level meson file. It's done the same way there. We could add the corresponding lines from here too so that the list of fields is "complete". So this meson file would only iterate over the programmers and add the source files to the srcs list.
> Just rethinking.. Actually, I'm unsure if this adds testsrc to the actual programmers definition or if it's just temporary within this scope. I need to test it.

Just tested it and it didn't work. It seems the modification is just temporary within that scope. Also, modifying the programmer dict is not possible since there is no setter function exposed, just a getter [1]. So we need to do it this way.

Setting the thread to resolved.

[1] https://mesonbuild.com/Reference-manual_elementary_dict.html