[S] Change in flashrom[master]: flashrom.c: create is_internal_programmer() helper - flashrom-gerrit

10 Oct 2022


      Attention is currently required from: Thomas Heijligen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66684 )
Change subject: flashrom.c: create is_internal_programmer() helper
......................................................................
Patch Set 10:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66684/comment/a72faecf_671c475d 
PS9, Line 9: This has the added benefit of cutting down one some
           : pre-processor usage as suggested by Angel Pons as the
           : function is always defined.
...
I find this a bit confusing. Suggestion: […]
Done with some grammatical fixes.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/66684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43243b990192077583a9a3a95d35844923d9c158
Gerrit-Change-Number: 66684
Gerrit-PatchSet: 10
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Mon, 10 Oct 2022 04:18:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Gerrit-MessageType: comment