Change in flashrom[master]: nicintel_spi.c: Refactor singleton states into reentrant pattern - flashrom-gerrit

27 May 2021


      Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54995 )
Change subject: nicintel_spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File nicintel_spi.c:
https://review.coreboot.org/c/flashrom/+/54995/comment/13ac18ef_c9812483 
PS1, Line 79: nicintel_
I'd drop the `nicintel_` prefix. This patch already adds `data->` to the code.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/54995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I385d3ced19dfe6453ccc4128a7b792c2dce3a449
Gerrit-Change-Number: 54995
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Thu, 27 May 2021 10:28:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment