[S] Change in flashrom[master]: flashrom.c: Retype appropriate variables with bool - flashrom-gerrit

7 Sep 2022


      Attention is currently required from: Felix Singer, Thomas Heijligen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66883 )
Change subject: flashrom.c: Retype appropriate variables with bool
......................................................................
Patch Set 12:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66883/comment/e15b29fa_552b0699 
PS12, Line 151: 	programmer_may_write = 1;
...
Right, I have done it in a follow up since multiple files need to be adjusted and so the commit titl […]
I wrote the "This smells boolean" part first, but then I noticed the follow-up when I was about to send my comment.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/66883
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6629f391284c8f1266e4ba66c9976f3df43955d4
Gerrit-Change-Number: 66883
Gerrit-PatchSet: 12
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Wed, 07 Sep 2022 12:26:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment