Attention is currently required from: Felix Singer, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71578 )
Change subject: internal.c: Factor out laptop alerts into helper func ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/71578/comment/70c4877f_70a6da22 PS1, Line 9: unfortant Did you mean `unfortunate`?
File internal.c:
https://review.coreboot.org/c/flashrom/+/71578/comment/c7872b7f_77acef64 PS1, Line 167: Add "from parameters", at first it seemed like this is about the function's name.
// FIXME: remove '_' suffix from parameters once global shadowing is fixed.
https://review.coreboot.org/c/flashrom/+/71578/comment/d037c1df_35b12832 PS1, Line 170: /* Report if a non-whitelisted laptop is detected that likely uses a legacy bus. */ Maybe keep this comment on the call site