Change in flashrom[master]: [WIP] flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
Attention is currently required from: Ravishankar Sarawadi, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025 )
Change subject: [WIP] flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58025/comment/dd100f43_f8413e4c PS1, Line 9: Tested using Servo: reading and writing works.
Also, mention how you tested it.
Done
https://review.coreboot.org/c/flashrom/+/58025/comment/ca288ce4_4efd356a PS1, Line 9: Tested using Servo: reading and writing works.
Also, mention how you tested it.
Done
https://review.coreboot.org/c/flashrom/+/58025/comment/1a5ce964_66e1fed4 PS1, Line 15: Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0
Missing a Signed-off-by line
Done
Commit Message:
https://review.coreboot.org/c/flashrom/+/58025/comment/09cb3fd5_b4217cec PS2, Line 10: Please use two spaces instead of tabs. Also below.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/58025/comment/74fe634d_ab6b6f70 PS1, Line 6349: : { : .vendor = "GigaDevice", : .name = "GD25LR256E", : .bustype = BUS_SPI, : .manufacture_id = GIGADEVICE_ID, : .model_id = GIGADEVICE_GD25LR256E, : .total_size = 32768, : .page_size = 256, : .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_WREN, : .tested = TEST_OK_PREW, : .probe = probe_spi_rdid, : .probe_timing = TIMING_ZERO, : .block_erasers = : { : { : .eraseblocks = { {4 * 1024, 8192} }, : .block_erase = spi_block_erase_21, : }, { : .eraseblocks = { {4 * 1024, 8192} }, : .block_erase = spi_block_erase_20, : }, { : .eraseblocks = { {32 * 1024, 1024} }, : .block_erase = spi_block_erase_5c, : }, { : .eraseblocks = { {32 * 1024, 1024} }, : .block_erase = spi_block_erase_52, : }, { : .eraseblocks = { {64 * 1024, 512} }, : .block_erase = spi_block_erase_dc, : }, { : .eraseblocks = { {64 * 1024, 512} }, : .block_erase = spi_block_erase_d8, : }, { : .eraseblocks = { {32 * 1024 * 1024, 1} }, : .block_erase = spi_block_erase_60, : }, { : .eraseblocks = { {32 * 1024 * 1024, 1} }, : .block_erase = spi_block_erase_c7, : } : }, : .printlock = spi_prettyprint_status_register_bp3_srwd, : .unlock = spi_disable_blockprotect, : .write = spi_chip_write_256, : .read = spi_chip_read, : .voltage = {1600, 2000}, : },
Please indent with tabs
Done
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/58025/comment/497e73d9_3dbe2610 PS2, Line 6452: }, Please use tabs
-
Felix Singer (Code Review)