Attention is currently required from: Michał Żygowski, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55577 )
Change subject: ich_descriptors.c: Fix PCH detection for Tiger Lake ......................................................................
Patch Set 1:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/55577/comment/29983d9f_90cd1673 PS1, Line 955: CHIPSET_300_SERIES_CANNON_POINT
It will be confusing, because 500 series is the Rocket Lake PCH and Tiger Point, well... […]
Intel refers to it as TGP (also for Rocket Lake), so Tiger Point seems likely. It wouldn't be the first time they re-use code names.
CHIPSET_500_SERIES_TIGER_POINT
would be unambiguous and fits our naming scheme.
These if's are getting pretty weird and it seems like much luck that FMSBA (or what is stored at that point now) is not `< 0x30`. Otherwise we'd run into the other block above. However, there is a more distinctive change: FLUMAP1[31:15] is not 0 anymore since 300 series. Checking for this (FLUMAP >> 16 == 0) in line 948 could make further checks easier, I guess. I've also noticed that a check for 400 series is missing (probably not easy to identify).
-
Nico Huber (Code Review)