Change in flashrom[master]: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call - flashrom-gerrit

26 May 2020


      Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c 
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c@402 
PS8, Line 402: 	/* 280 Byte = (9 Byte CMD + 1 Byte WREN) + (9 Byte CMD + 1 Byte op) + 4 Byte Addr
...
This comment would need an extra tab and could be tidied up. Maybe use: […]
Done
https://review.coreboot.org/c/flashrom/+/40477/8/ft2232_spi.c@480 
PS8, Line 480: ftdi
...
FTDI (and missing a space before the comment closes)
Done
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/40477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 10
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 May 2020 09:49:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment