Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/45438 )
Change subject: tests: Update licence headers ......................................................................
tests: Update licence headers
Signed-off-by: Nikolai Artemiev nartemiev@google.com Change-Id: Ia964279ace569b4b93f4e2919c1c228a9b621745 --- M tests/flashrom.c M tests/helpers.c M tests/include/test.h M tests/meson.build M tests/spi25.c M tests/tests.c M tests/tests.h 7 files changed, 101 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/45438/1
diff --git a/tests/flashrom.c b/tests/flashrom.c index ad46dd8..50464dd 100644 --- a/tests/flashrom.c +++ b/tests/flashrom.c @@ -1,3 +1,18 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #include <include/test.h>
#include "programmer.h" diff --git a/tests/helpers.c b/tests/helpers.c index ab0863f..a920c15 100644 --- a/tests/helpers.c +++ b/tests/helpers.c @@ -1,3 +1,18 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #include <include/test.h>
#include "flash.h" diff --git a/tests/include/test.h b/tests/include/test.h index b4e0dd2..24fa963 100644 --- a/tests/include/test.h +++ b/tests/include/test.h @@ -1,5 +1,17 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */
#ifndef _TESTS_TEST_H #define _TESTS_TEST_H diff --git a/tests/meson.build b/tests/meson.build index b1f9fda..f0cb76d 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -1,3 +1,16 @@ +# This file is part of the flashrom project. +# +# Copyright 2020 Google LLC +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + root_includes = include_directories('../subprojects')
srcs = [ diff --git a/tests/spi25.c b/tests/spi25.c index aa1eea0..6ad0357 100644 --- a/tests/spi25.c +++ b/tests/spi25.c @@ -1,3 +1,18 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #include <include/test.h>
#include "programmer.h" diff --git a/tests/tests.c b/tests/tests.c index 1a6b65f..3124607 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -1,5 +1,17 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */
#include <include/test.h> #include "tests.h" diff --git a/tests/tests.h b/tests/tests.h index 107cb51..cb905fd 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -1,3 +1,18 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #ifndef TESTS_H #define TESTS_H
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45438 )
Change subject: tests: Update licence headers ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45438 )
Change subject: tests: Update licence headers ......................................................................
Patch Set 1:
This would need a rebase now that CB:45431 has been merged. Also, it would be nice if we could have tests for the cache.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45438 )
Change subject: tests: Update licence headers ......................................................................
Patch Set 1: Code-Review+1
Patch Set 1:
This would need a rebase now that CB:45431 has been merged. Also, it would be nice if we could have tests for the cache.
Agreed, please improve the test cov for the cache.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45438 )
Change subject: tests: Update licence headers ......................................................................
Patch Set 2: Code-Review+2
Patch Set 1: Code-Review+1
This would need a rebase now that CB:45431 has been merged.
I rebased this CL on top of master so that it passes the builder.
Also, it would be nice if we could have tests for the cache.
Agreed, please improve the test cov for the cache.
I think that's out of scope for this commit, though?
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45438 )
Change subject: tests: Update licence headers ......................................................................
Patch Set 2: Code-Review+2
Patch Set 2: Code-Review+2
Patch Set 1: Code-Review+1
This would need a rebase now that CB:45431 has been merged.
I rebased this CL on top of master so that it passes the builder.
Also, it would be nice if we could have tests for the cache.
Agreed, please improve the test cov for the cache.
I think that's out of scope for this commit, though?
Yep, that's also fair to say.
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/45438 )
Change subject: tests: Update licence headers ......................................................................
tests: Update licence headers
Signed-off-by: Nikolai Artemiev nartemiev@google.com Change-Id: Ia964279ace569b4b93f4e2919c1c228a9b621745 Reviewed-on: https://review.coreboot.org/c/flashrom/+/45438 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M tests/flashrom.c M tests/helpers.c M tests/include/test.h M tests/meson.build M tests/spi25.c M tests/tests.c M tests/tests.h 7 files changed, 101 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved
diff --git a/tests/flashrom.c b/tests/flashrom.c index ad46dd8..50464dd 100644 --- a/tests/flashrom.c +++ b/tests/flashrom.c @@ -1,3 +1,18 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #include <include/test.h>
#include "programmer.h" diff --git a/tests/helpers.c b/tests/helpers.c index ab0863f..a920c15 100644 --- a/tests/helpers.c +++ b/tests/helpers.c @@ -1,3 +1,18 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #include <include/test.h>
#include "flash.h" diff --git a/tests/include/test.h b/tests/include/test.h index b4e0dd2..24fa963 100644 --- a/tests/include/test.h +++ b/tests/include/test.h @@ -1,5 +1,17 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */
#ifndef _TESTS_TEST_H #define _TESTS_TEST_H diff --git a/tests/meson.build b/tests/meson.build index b1f9fda..f0cb76d 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -1,3 +1,16 @@ +# This file is part of the flashrom project. +# +# Copyright 2020 Google LLC +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + root_includes = include_directories('../subprojects')
srcs = [ diff --git a/tests/spi25.c b/tests/spi25.c index 362f5c6..942fe6e 100644 --- a/tests/spi25.c +++ b/tests/spi25.c @@ -1,3 +1,18 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #include <include/test.h>
#include "programmer.h" diff --git a/tests/tests.c b/tests/tests.c index 1a6b65f..3124607 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -1,5 +1,17 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */
#include <include/test.h> #include "tests.h" diff --git a/tests/tests.h b/tests/tests.h index 107cb51..cb905fd 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -1,3 +1,18 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #ifndef TESTS_H #define TESTS_H
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)
-
Nikolai Artemiev (Code Review)
-
Patrick Georgi (Code Review)