Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66659 )
Change subject: flashrom.c: Remove programmer_param global state
......................................................................
Patch Set 15:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66659/comment/279da419_3fa3693b
PS15, Line 171: const struct programmer_cfg cfg = { .params = strdup(param) };
Where did the NULL check for `param` go? Why is strdup() needed now? And what if `strdup()` returns NULL?
https://review.coreboot.org/c/flashrom/+/66659/comment/f17d12ce_eedaee6e
PS15, Line 174: free(cfg.params);
Doesn't this result in use-after-free problems?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I778609e370e44ad2b63b8baa4984ac03ff4124d8
Gerrit-Change-Number: 66659
Gerrit-PatchSet: 15
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Tue, 13 Sep 2022 15:24:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment