Attention is currently required from: Edward O'Callaghan, Felix Singer, Nico Huber, Angel Pons, Anastasia Klimchuk. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60055 )
Change subject: SFDP: make mandatory table length check work with newer SFDP revisions ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/60055/comment/7ad73dbb_cf729508 PS1, Line 28: ***RFC*** We could maintain a list of revisions/lengths but is it really : worth it? :
and that the major version is 1. […]
Ack. I chose the first version
Commit Message:
https://review.coreboot.org/c/flashrom/+/60055/comment/67815070_fd202944 PS2, Line 9: JESD216F (1.6) released in September 2021 : adds three new DWORDs
JESD216A r1.5: adds 5 new DWORDs. ... later revisions add even more... so any chip with SFDP >= r1. […]
Done
https://review.coreboot.org/c/flashrom/+/60055/comment/04321ddb_c0bdb87c PS2, Line 11: 32
9*4=36.
Done
https://review.coreboot.org/c/flashrom/+/60055/comment/b4732efb_32ea6491 PS2, Line 24:
let's add the output here […]
Done
File sfdp.c:
https://review.coreboot.org/c/flashrom/+/60055/comment/6befb33f_15ffff6e PS2, Line 372: } else if (sfdp_fill_flash(flash->chip, tbuf, len) == 0)
yes
redundancy dropped in CB:61379