Attention is currently required from: Felix Singer, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69842 )
Change subject: opaque_master: Mark Opaque chip as tested for WP ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69842/comment/f5a17bac_ca272fe1 PS1, Line 9: Opaque masters by design are populating information about a flashchip : on the runtime inside their probe function.
I had a hard time parsing this. I think you mean to say: […]
Done
https://review.coreboot.org/c/flashrom/+/69842/comment/944d9cbe_753bbdf8 PS1, Line 10: For the user the chip : is visible as "Opaque flash chip".
delete.
Done
https://review.coreboot.org/c/flashrom/+/69842/comment/b2192945_42320933 PS1, Line 11: Without this patch, any operation : on opaque flash chip
"Therefore any opaque master operation"
Done
https://review.coreboot.org/c/flashrom/+/69842/comment/c2b03abe_ebf71f14 PS1, Line 13: and advises : to report on the mailing list. However, this is not very useful in : the case of Opaque chip. :
delete and stop sentence here ". […]
Done
https://review.coreboot.org/c/flashrom/+/69842/comment/1c3c9964_7065f9fd PS1, Line 17: For
"However, for"
Done
https://review.coreboot.org/c/flashrom/+/69842/comment/21998f6f_033661ec PS1, Line 18: So it seems in line with opaque design : to mark WP as tested too.
"Thus, align WP as marked tested inline with other opaque chip operations. […]
Done
-
Anastasia Klimchuk (Code Review)