Change in flashrom[master]: cli_classic: Make -r/-w/-v argument optional - flashrom-gerrit

15 Apr 2021


      Attention is currently required from: Nico Huber, Daniel Campello, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52362 )
Change subject: cli_classic: Make -r/-w/-v argument optional
......................................................................
Patch Set 1:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/52362/comment/18ea30e9_734af317 
PS1, Line 140: static char *get_optional_filename(char *argv[])
...
The diff is for a different functionality. […]
ACK. Do you mind just encoding that in the commit message so we remember this detail in the diff or via a BUG= line
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52362
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41
Gerrit-Change-Number: 52362
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Campello campello@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Nikolai Artemiev nartemiev@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Daniel Campello campello@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 15 Apr 2021 04:38:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Daniel Campello campello@chromium.org
Gerrit-MessageType: comment