Attention is currently required from: Nico Huber, David Hendricks, Julius Werner, Angel Pons, Arthur Heymans. Hello build bot (Jenkins), Nico Huber, David Hendricks, Edward O'Callaghan, Angel Pons, Arthur Heymans, Nikolai Artemiev,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/61943
to look at the new patch set (#3).
Change subject: libflashrom/fmap: Don't use off_t for flash offsets ......................................................................
libflashrom/fmap: Don't use off_t for flash offsets
off_t is a special POSIX type that is used to represent file offsets in certain APIs (e.g. lseek(), mmap()), and should not be reused to represent anything else (such as flash offsets). In particular, the width of the type may change based on the definition of the _FILE_OFFSET_BITS macro. Using such a type at the libflashrom interface is particularly dangerous, because if a program is built with a different _FILE_OFFSET_BITS value than libflashrom, the resulting ABI corruption will cause very very nasty and confusing bugs. This patch replaces all instances of off_t that are not related to file offsets with (s)size_t.
BUG=b:219811851 TEST=`elogtool list` on cherry.
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee --- M fmap.c M libflashrom.c M libflashrom.h 3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/61943/3