Change in ...flashrom[master]: Rework internal bus handling and laptop bail-out - flashrom-gerrit

3 Jun 2019


      Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/28716 )
Change subject: Rework internal bus handling and laptop bail-out
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Looks fine
https://review.coreboot.org/#/c/28716/5/internal.c 
File internal.c:
https://review.coreboot.org/#/c/28716/5/internal.c@285 
PS5, Line 285: is_laptop && !(laptop_ok
Could we have enums for is_laptop and laptop_ok?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/28716
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1dbda8cf0c10d7786106f14f0d18c3dcce35f0a3
Gerrit-Change-Number: 28716
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Jun 2019 22:41:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment