Change in flashrom[master]: Introduce an `include` directory for header files - flashrom-gerrit

25 Apr 2022


      Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58622 )
Change subject: Introduce an `include` directory for header files
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/58622/comment/a68ff78f_a63511e8 
PS4, Line 994: libflashrom.h
Needs same update as `meson.build`.
File platform/endian_big.c:
https://review.coreboot.org/c/flashrom/+/58622/comment/64a9c62f_181f3ced 
PS4, Line 18: #include "platform.h"
These should become <platform.h> sooner or later.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58622
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iaddd6bbfa0624b166d422f665877f096983bf4cf
Gerrit-Change-Number: 58622
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin L Roth martinroth@google.com
Gerrit-CC: Peter Marheine pmarheine@chromium.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 25 Apr 2022 11:02:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment