Change in flashrom[master]: [UNTESTED] bitbang_spi.c: Support changing clock polarity and phase - flashrom-gerrit

10 Jan 2021


      Attention is currently required from: Angel Pons.
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49271 )
Change subject: [UNTESTED] bitbang_spi.c: Support changing clock polarity and phase
......................................................................
Patch Set 1:
(1 comment)
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/49271/comment/d5e6e3ce_ec6d4f99 
PS1, Line 71: cpha
I think you need to take a closer look at https://en.wikipedia.org/wiki/Serial_Peripheral_Interface#Clock_polarity_and.... cpha does not mean this.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/49271
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I415a528c013f1a523e883d812b6890be39bfcc7b
Gerrit-Change-Number: 49271
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Xiang Wang merle@hardenedlinux.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 10 Jan 2021 14:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment