Attention is currently required from: Paul Menzel, Edward O'Callaghan, Anastasia Klimchuk.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62862 )
Change subject: helpers.c: use unsigned int for bit shifts (ASAN)
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62862/comment/3673ab6a_02a582a6
PS2, Line 11: error detected
Lets say "error detected in chromium tree", that would explain where flashrom-9999 is coming from.
This is the output verbatim, I added the chromium remark in the line above
https://review.coreboot.org/c/flashrom/+/62862/comment/f924ba5c_ab09e91b
PS2, Line 18: TEST=FEATURES=test emerge-amd64-generic flashrom
You probably ran tests in upstream tree too (before sending the patch)? (meson tests). […]
Added the test done with ./test_build.sh
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib595f13c29dd5c0775e074801756e4f920b4daaf
Gerrit-Change-Number: 62862
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 17 Mar 2022 23:32:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment