Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75271 )
Change subject: chipset_enable.c: Drop `_LARGEFILE64_SOURCE`
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Also see Nico's comment on CB:75272
Docs (`info libc`) are quite explicit about the macro only exposing additional
functions and types with *64* in their names. manibuilder agrees too.
Can we mark this as resolved?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/75271
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I866cfa2f996eeea5846e5d9189647ad7a4a4e3e4
Gerrit-Change-Number: 75271
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alexander Goncharov
chat@joursoir.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Thu, 18 May 2023 17:48:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment