Attention is currently required from: Nikolai Artemiev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 )
Change subject: ichspi.c: Read chip ID and use it to populate `flash->chip`
......................................................................
Patch Set 12:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69195/comment/59696b58_79997a2e
PS2, Line 7: ichspi.c: Read chip ID and use it to identify chip
Subrata can you take a look too please.
There aren't that many systems with 2 flash chips, but they exist. Ivy Bridge and Haswell ThinkPads have a 8 MiB chip and a 4 MiB chip, and flashrom detects a single 12 MiB opaque flash chip. The problem with sending WP commands in such situations is that you have 2 chips to deal with. No idea how hwseq handles this.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia408e1e45dc6f53c0934afd6558e301abfa48ee6
Gerrit-Change-Number: 69195
Gerrit-PatchSet: 12
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Wed, 07 Dec 2022 10:55:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment