Change in flashrom[master]: cli_classic: prevent corruption of flash when stdout/stderr is closed - flashrom-gerrit

15 Apr 2021


      Attention is currently required from: Jack Rosenthal, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52215 )
Change subject: cli_classic: prevent corruption of flash when stdout/stderr is closed
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2: 
Looks nice, thank you!
NB. I wonder why we have these STANDALONE guards. The only target
defining this seems to be libflashrom for a libpayload environment,
which doesn't include the CLI.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I751c9dd88ad1d30283b94bd2185b4f8f25569c8f
Gerrit-Change-Number: 52215
Gerrit-PatchSet: 2
Gerrit-Owner: Jack Rosenthal jrosenth@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jack Rosenthal jrosenth@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 15 Apr 2021 19:32:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment