Attention is currently required from: Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51761 )
Change subject: Accept shutdown function in register_master
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Thanks heaps for +2s this is so cool!
I am currently working on the next patch in the series, which implements register_shutdown in register_master and takes care of memory management for data (data being second parameter in register_shutdown). I wanted to get the next patch in working state before merging this, just in case any changes would be needed here (size of data for example). So I would hold this one from merging until I get the next one, hope it’s fine.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/51761
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1704ddafc56e1393613a7ea077e40c36911cfac8
Gerrit-Change-Number: 51761
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nikolai Artemiev
nartemiev@google.com
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 29 Mar 2021 05:04:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment