Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55123 )
Change subject: CONFIG_DEFAULT_PROGRAMMER_NAME: Use programmer name instead of enum
......................................................................
Patch Set 10:
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/55123/comment/00edbc54_bf5af7b6
PS10, Line 448: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"'
Doesn't this work for an empty string as well?
I'll try
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55123
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I976447787c6f6bfbdc0145d80d61e1ddcf97ac33
Gerrit-Change-Number: 55123
Gerrit-PatchSet: 10
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Xiang W
wxjstz@126.com
Gerrit-Comment-Date: Tue, 08 Jun 2021 15:02:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment