Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/20784 )
Change subject: rpci: Use pci_dev struct pointer to avoid API breaks ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/20784/1/pcidev.c File pcidev.c:
https://review.coreboot.org/#/c/20784/1/pcidev.c@297 PS1, Line 297:
Yes, the code was and is still checking the `pacc` pointer in
It's not really nuts, it makes sense because the pci_access gets referenced in the pci_dev, and is used, so if the pacc is cleaned up and destroyed, then calling any pci_dev API will cause an error. The mistake here is that 'pacc' is not set to NULL after cleanup in its shutdown routine. Of course, this makes no more sense if the pacc variable is different like in the case of pch100, that check becomes wrong.
https://review.coreboot.org/#/c/20784/2/programmer.h File programmer.h:
https://review.coreboot.org/#/c/20784/2/programmer.h@200 PS2, Line 200: int rpci_write_word(struct pci_dev *dev, int reg, uint16_t data);
That's not accurate... how about:
Sounds good to me. Thanks
-
Youness Alaoui (Code Review)