Change in flashrom[master]: programmer.h,chipset_enable.c: Make penable cb more descript
Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52364 )
Change subject: programmer.h,chipset_enable.c: Make penable cb more descript ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52364/comment/a49d605d_d403fe88 PS1, Line 7: Make penable cb more descript
Maybe it's just me, but `cb` resolves to `coreboot`. How about: […]
It's not a callback anyway. It's a function pointer used for a dispatch mechanism. As `penable` binds the pointer to data one could also call it method (as in object-oriented programming).
A callback is when a() is calling b() passing a1() and b is calling back into the context of a via a1. Sometimes the definition is a little stretched to include cases where the passed function is not directly related to a. But the common pattern is that the original caller decides, by specifying the callback, what will be called eventually.
File programmer.h:
https://review.coreboot.org/c/flashrom/+/52364/comment/2819bc18_475d66bc PS1, Line 228: enable_flash_xxx
I'd prefer `enable_flash` too.
How about `run` or anything else that doesn't repeat `enable`.
-
Nico Huber (Code Review)