Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54854 )
Change subject: dummyflasher.c: Replace atoi() with strtoul()
......................................................................
Patch Set 3:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54854/comment/7e36d786_cc759264
PS3, Line 715: free(tmp);
Sigh, this introduces a use-after-free bug... CB:46551 and CB:54909 fixed the same kind of thing. […]
damm it. thanks Angle fixed here https://review.coreboot.org/c/flashrom/+/55014
I do want to not get too much in the way of Anastasia project though, I just wanted to unblock a couple of things.
Thanks again so much.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54854
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e66016a2f4ce2d13b833c261f900cab80916b7
Gerrit-Change-Number: 54854
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 May 2021 12:41:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment